Hemiptera Bugtracker at bugs.linux-forks.de

Using the master branch, at commit 5d372b1c. Running under Minetest 5.4.0 with Dreambuilder game (which is basically minetest_game with a metric assload of mods). Other trains mods installed: basic_trains, disco_trains, minetest-moretrains.

The main advtrains mod is missing a dependency on mesecons_switch, resulting in a crash at startup. Adding it to depends in advtrains' mod.conf fixes that (I didn't test if it actually needs to be a hard depend vs. optional). That crash:

```

2021-03-25 05:29:17: ERROR[Main]: ModError: Failed to load and run script from /home/minetest/.minetest/worlds/Creative_World/worldmods/advtrains/advtrains/init.lua:

2021-03-25 05:29:17: ERROR[Main]: ..._World/worldmods/advtrains/advtrains/p_mesecon_iface.lua:6: Attempt to override non-existent item mesecons_switch:mesecon_switch_off

2021-03-25 05:29:17: ERROR[Main]: stack traceback:

2021-03-25 05:29:17: ERROR[Main]: [C]: in function 'error'

2021-03-25 05:29:17: ERROR[Main]: /usr/share/minetest/builtin/game/register.lua:395: in function 'override_item'

2021-03-25 05:29:17: ERROR[Main]: ..._World/worldmods/advtrains/advtrains/p_mesecon_iface.lua:6: in main chunk

2021-03-25 05:29:17: ERROR[Main]: [C]: in function 'dofile'

```

--

"There are some things in life worth obsessing over.  Most

things aren't, and when you learn that, life improves."

Vanessa Dannenberg <vanessa.e.dannenberg@gmail.com>

I have sent a patch to the mailing list that makes mesecons_switch a

proper optional dependency in mod.conf as well as a check for the

modpath of mesecons_switch at the top of p_mesecon_iface.lua

Just+a+note: it's not usually Just a note: it's not usually considered good practice to close a bug before the fix has been merged into the publicly-available code. :-)

--

"There are some things in life worth obsessing over.  Most

things aren't, and when you learn that, life improves."

Vanessa Dannenberg <vanessa.e.dannenberg@gmail.com>

Also, fix your reply function, it spawns an email compose window (for me, that's claws-mail), but spaces in here are replaced with "+" in the email, forcing me to copy-paste from here to the composer (and making mistakes :-P).

--

"There are some things in life worth obsessing over.  Most

things aren't, and when you learn that, life improves."

Vanessa Dannenberg <vanessa.e.dannenberg@gmail.com>

Sorry, I have indeed merged a fix, i simply forgot to push it :/

The fact that I haven't added a note is due to a "feature" of hemiptera-

you can't close a bug and add a reply to it in one email, and to my

laziness.

On 31.03.21 03:34, 175@bugs.linux-forks.de wrote:

> Just+a+note: it's not usually Just a note: it's not usually considered good practice to close a bug before the fix has been merged into the publicly-available code. :-)

>