Hemiptera Bugtracker at bugs.linux-forks.de

From 3b2f51213ddea2a5e5d895af1261ef36ebf17725 Mon Sep 17 00:00:00 2001

From: Blockhead <jbis1337@hotmail.com>

Date: Sun, 28 Jun 2020 23:39:32 +1000

Subject: [PATCH] Fix access control to wagon properties

Previously, players were able to open the wagon properties of any wagon at

all

through the wagon properties button on the inventory formspec and through

the

wagon buttons on the onboard computer. Add a check for ownership before

allowing players to open wagon properties.

---

advtrains/wagons.lua | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/advtrains/wagons.lua b/advtrains/wagons.lua

index c44cd9c..2b0833d 100644

--- a/advtrains/wagons.lua

+++ b/advtrains/wagons.lua

@@ -921,7 +921,7 @@ function wagon:handle_bordcom_fields(pname, formname,

fields)

advtrains.safe_decouple_wagon(tpid, pname)

elseif fields["wgprp"..i] then

for _,wagon in pairs(minetest.luaentities) do

- if wagon.is_wagon and wagon.initialized and wagon.id==tpid then

+ if wagon.is_wagon and wagon.initialized and wagon.id==tpid and

data.owner==pname then

wagon:show_wagon_properties(pname)

return

end

@@ -1029,7 +1029,7 @@

minetest.register_on_player_receive_fields(function(player, formname,

fields)

local data = advtrains.wagons[uid]

if fields.prop and data.owner==pname then

for _,wagon in pairs(minetest.luaentities) do

- if wagon.is_wagon and wagon.initialized and wagon.id==uid then

+ if wagon.is_wagon and wagon.initialized and wagon.id==uid and

data.owner==pname then

wagon:show_wagon_properties(pname)

--wagon:handle_bordcom_fields(player:get_player_name(), formname, fields)

end

--

2.21.0.windows.1

merged