Hemiptera Bugtracker at bugs.linux-forks.de

When I see a running steam engine, its sound is played endlessly and

doesn't fade out when the train is gone. It stops if and only if I

disconnect.

Take a trip by railway 56 with sounds on and then enjoy all the sounds

played endlessy.

If you don't know how to fix it, please, just remove the sound, it's

terrible.

This is one example of an easy to fix bug (remove the sound), which is

there since much longer as 1 year

It seems like this problem can be easily solved without removing the sound:

local function steam_sound_loop(self, dtime, train)

if train.velocity > 0 then -- First make sure that the train isn't standing

if self.sound_loop_handle == nil then -- Make sure that the sound isn't played

self.sound_loop_handle = minetest.sound_play({name="advtrains_steam_loop", gain=2}, {object=self.object})

self.sound_loop_tmr = 0 -- Start timer

else -- Check if the sound is no longer played

if self.sound_loop_tmr == nil then

self.sound_loop_tmr = 0 -- Add the timer if it doesn't exist

else

self.sound_loop_tmr = self.sound_loop_tmr + dtime -- Add up the timer

if self.sound_loop_tmr >= 5 then -- Make sure that the sound is played for enough time

self.sound_loop_handle = nil -- The sound is no longer played

self.sound_loop_tmr = nil -- Clear the timer

end

end

end

-- If the train is standing, the sound will be stopped in some time. We do not need to interfere with it.

end

end

advtrains.register_wagon("detailed_steam_engine", {

mesh="advtrains_detailed_steam_engine.b3d",

textures = {"advtrains_detailed_steam_engine.png"},

is_locomotive=true,

drives_on={default=true},

max_speed=10,

seats = {

{

name=S("Driver Stand (left)"),

attach_offset={x=-5, y=10, z=-10},

view_offset={x=9, y=-2, z=-6},

group = "dstand",

},

{

name=S("Driver Stand (right)"),

attach_offset={x=5, y=10, z=-10},

view_offset={x=0, y=6, z=0},

group = "dstand",

},

},

seat_groups = {

dstand={

name = "Driver Stand",

driving_ctrl_access=true,

access_to = {},

},

},

assign_to_seat_group = {"dstand"},

visual_size = {x=1, y=1},

wagon_span=2.05,

collisionbox = {-1.0,-0.5,-1.0, 1.0,2.5,1.0},

custom_on_velocity_change=function(self, velocity)

if self.old_anim_velocity~=advtrains.abs_ceil(velocity) then

self.object:set_animation({x=1,y=80}, advtrains.abs_ceil(velocity)*15, 0, true)

self.old_anim_velocity=advtrains.abs_ceil(velocity)

end

end,

custom_on_step = function(self,dtime,data,train)

steam_sound_loop(self,dtime,train)

end,

custom_on_activate = function(self, staticdata_table, dtime_s)

minetest.add_particlespawner({

amount = 10,

time = 0,

-- ^ If time is 0 has infinite lifespan and spawns the amount on a per-second base

minpos = {x=0, y=2.3, z=1.45},

maxpos = {x=0, y=2.3, z=1.4},

minvel = {x=-0.2, y=1.8, z=-0.2},

maxvel = {x=0.2, y=2, z=0.2},

minacc = {x=0, y=-0.1, z=0},

maxacc = {x=0, y=-0.3, z=0},

minexptime = 2,

maxexptime = 4,

minsize = 1,

maxsize = 5,

-- ^ The particle's properties are random values in between the bounds:

-- ^ minpos/maxpos, minvel/maxvel (velocity), minacc/maxacc (acceleration),

-- ^ minsize/maxsize, minexptime/maxexptime (expirationtime)

collisiondetection = true,

-- ^ collisiondetection: if true uses collision detection

vertical = false,

-- ^ vertical: if true faces player using y axis only

texture = "smoke_puff.png",

-- ^ Uses texture (string)

attached = self.object,

})

end,

drops={"default:steelblock 1"},

horn_sound = "advtrains_steam_whistle",

glow = -1, --supposed to disable effect of light to texture color, so that the entity always appears as full-bright

craft = {recipe = {

{'', '', 'advtrains:chimney'},

{'advtrains:driver_cab', 'dye:green', 'advtrains:boiler'},

{'advtrains:wheel', 'advtrains:wheel', 'advtrains:wheel'},

}}

}, S("Detailed Steam Engine"), "advtrains_detailed_engine_steam_inv.png")